flake: Test_batcherFlush/RetriesOnTransientFailure

[flake-investigator]

CI Run: https://github.com/coder/coder/actions/runs/24074920439 (job: test-go-pg (ubuntu-latest))
Commit: 8913f9f5c1aa6cbd13f7e08c3bca16160aa1c2dd (Danielle Maywood)

Failure summary

• Go test failed in enterprise/coderd/connectionlog: Test_batcherFlush/RetriesOnTransientFailure

Error excerpt

=== FAIL: enterprise/coderd/connectionlog Test_batcherFlush/RetriesOnTransientFailure (0.00s)
    mock.go:442: Mock Clock - Trap Timer.Reset(..., [connectionLogBatcher scheduledFlush])
    mock.go:196: Mock Clock - NewTimer(5s, []) call, matched 0 traps
    connectionlog_internal_test.go:387: Mock Clock - Advance(5s)
    mock.go:196: Mock Clock - Timer.Reset(5s, [connectionLogBatcher scheduledFlush]) call, matched 1 traps
    mock.go:196: Mock Clock - Timer.Stop([]) call, matched 0 traps
    controller.go:97: missing call(s) to *dbmock.MockStore.BatchUpsertConnectionLogs(...)
    controller.go:97: aborting test due to missing call(s)

Root cause classification

• Flaky test / timing: mock clock + scheduled flush causes expected BatchUpsertConnectionLogs call to be missed.
• No data race warnings found.
• No panic/OOM indicators found.

Assignment analysis (best effort)

• git blame is unavailable in this environment.
• git log --oneline -10 --follow enterprise/coderd/connectionlog/connectionlog_internal_test.go → a1d51f0d (Jon Ayers, 2026-04-03) introduced the batcher tests.
• git log --oneline -10 --follow enterprise/coderd/connectionlog → most recent known owner in this area is Spike Curtis (bddb808b, 2026-01-08).
• Assigning to Spike Curtis for component ownership (couldn’t map Jon Ayers to a GitHub login).

Related issues

• None found in coder/internal for Test_batcherFlush or connectionlog_internal_test.go.

Reproduction

• go test ./enterprise/coderd/connectionlog -run Test_batcherFlush/RetriesOnTransientFailure -count=1

[flake-investigator]

New occurrence:

• CI run: https://github.com/coder/coder/actions/runs/24097615136 (job: test-go-pg-17)
• Commit: c5f1a2fccf9e4ac4432311f702b6b74dcb771f03 (Kayla はな)

Failure excerpt

=== FAIL: enterprise/coderd/connectionlog Test_batcherFlush/ShutdownDrainsRetryQueue (0.00s)
    mock.go:442: Mock Clock - Trap Timer.Reset(..., [connectionLogBatcher scheduledFlush])
    mock.go:196: Mock Clock - NewTimer(5s, []) call, matched 0 traps
    connectionlog_internal_test.go:433: Mock Clock - Advance(5s)
    mock.go:196: Mock Clock - Timer.Reset(5s, [connectionLogBatcher scheduledFlush]) call, matched 1 traps
    mock.go:196: Mock Clock - Timer.Stop([]) call, matched 0 traps
    connectionlog_internal_test.go:442:
        Error: []uuid.UUID(nil) does not contain uuid.UUID{...}
        Messages: event should be written during shutdown drain

Notes

• Same test family (Test_batcherFlush) and similar mock clock timing behavior as earlier flake.
• No data race warnings.
• No panic/OOM indicators.

[sreya]

stale, this emerged right before my fix was merged