flake: TestPortableDesktop_IdleTimeout_StopsRecordings

[flake-investigator]

CI Run Link: https://github.com/coder/coder/actions/runs/24240850729
Failing Job: https://github.com/coder/coder/actions/runs/24240850729/job/70774820801 (test-go-pg (macos-latest))
Commit: 4018320614db6a1e001d06b5db94e7979733b65a (Jake Howell) coder/coder@4018320

Failure summary:

• TestPortableDesktop_IdleTimeout_StopsRecordings failed on macOS only.
• Error output:

FAIL: agent/x/agentdesktop TestPortableDesktop_IdleTimeout_StopsRecordings
mock.go:196: Mock Clock - Now([]) call, matched 0 traps
mock.go:442: Mock Clock - Trap NewTimer(..., [agentdesktop recording_idle])
...
Error: Condition never satisfied
Test: TestPortableDesktop_IdleTimeout_StopsRecordings

• The test timed out waiting for the recording to stop after advancing the mock clock (require.Eventually in portabledesktop_internal_test.go:822).

Root cause classification: Flaky test (timing/synchronization around mock clock timer and recording stop). No panic/OOM/race indicators found in logs.

Precise assignment analysis:

• Expected blame: git blame -L 780,845 agent/x/agentdesktop/portabledesktop_internal_test.go (failing test function).
• Tooling fallback used: git log --oneline -10 --follow agent/x/agentdesktop/portabledesktop_internal_test.go
  • Most recent substantive changes touch the desktop recording feature: efb19eb (Hugo Dutka) “feat: agents desktop recording thumbnail backend”.
• Component context: git log --oneline -20 agent/x/agentdesktop shows the same recent ownership (Hugo Dutka) around desktop recording changes.
• Assigning to Hugo Dutka as the most recent meaningful modifier of the test/component.

Reproduction (best effort):

• go test ./agent/x/agentdesktop -run TestPortableDesktop_IdleTimeout_StopsRecordings -count=50 on macOS

Notes:

• Failure occurred at 2026-04-10 11:36:52Z, within minutes of the Slack notification.