flake: TestWatchChats/DiffStatusChangeIncludesDiffStatus

[flake-investigator]

CI Run: https://github.com/coder/coder/actions/runs/24344988785
Job: test-go-pg-17 (https://github.com/coder/coder/actions/runs/24344988785/job/71083363763)
Commit: 6ab30123bfa7b75580d5b13528e7fa2aaea38a54 (Thomas Kosiewski) coder/coder@6ab3012

Failure:

• Test: coderd TestWatchChats/DiffStatusChangeIncludesDiffStatus
• File: coderd/exp_chats_test.go (function starts ~1400; failure logged at line 1574)
• Error: failed to read JSON message: failed to get reader: context deadline exceeded

Log excerpt:

exp_chats_test.go:1574:
    Error:       Received unexpected error:
                 failed to read JSON message: failed to get reader: context deadline exceeded
    Test:        TestWatchChats/DiffStatusChangeIncludesDiffStatus

Root cause assessment:

• Flaky test / timing: websocket watch event not received before the test context deadline. No data race warnings, panics, or OOM indicators observed in the job logs.

Assignment analysis:

• Intended blame target: coderd/exp_chats_test.go → TestWatchChats (subtest DiffStatusChangeIncludesDiffStatus).
• I can’t run git blame directly with current tooling, so I used file history + commit diff as a proxy:
  • git log --oneline -10 --follow coderd/exp_chats_test.go (API) shows recent substantive changes in commit 38d4da82 (“refactor: send raw typed payloads over chat WebSockets”) by Danielle Maywood, which reworked watchChats and updated TestWatchChats expectations.
• Assigning to @DanielleMaywood as the most recent meaningful modifier in this test area. If a different owner is more appropriate, please reassign.

Related issues (searched, none found):

• "TestWatchChats"
• "DiffStatusChangeIncludesDiffStatus"
• "failed to read JSON message"
• "exp_chats_test"
• "chats watch timeout"

Reproduction (if needed):

go test ./coderd -run TestWatchChats/DiffStatusChangeIncludesDiffStatus -count=1

[rsmihir389]

Hey — I've been seeing this pattern a lot. Flaky tests like this usually cost teams $30-40 per rerun in CI time + developer context-switching.

I built a tool that detects flaky tests and shows the dollar cost: kleore.com. Here's what a report looks like on a real repo: sample report.

60-second install as a GitHub App, free tier shows the cost. Might help here.

[DanielleMaywood]

Should be fixed by coder/coder#24298