CI Run: https://github.com/coder/coder/actions/runs/24372016078
Commit: 3d8d89e56cbf3a777b8eea1ac933751aa54ba800 (feat: add texlive.svg icon (#24312)) by DevCats christofer@coder.com
Failing jobs:
- test-go-pg (ubuntu-latest)
- test-go-pg-17
- test-go-race-pg
Error:
=== FAIL: scripts/gensite TestSVGIconAttributes/texlive.svg (0.00s)
generate_icon_list_test.go:53:
Error: Not equal:
expected: "0 0 256 256"
actual : "0 0 1024 1024"
Messages: SVG must have viewBox="0 0 256 256"
Root cause classification: Code change. The newly added site/static/icon/texlive.svg has viewBox="0 0 1024 1024", which violates TestSVGIconAttributes’s requirement for viewBox="0 0 256 256".
Race detection: Searched test-go-race-pg logs for "WARNING: DATA RACE" / "race detected"; none found.
Panic/OOM: none observed.
Assignment analysis:
git blame -L 14,40 scripts/gensite/generate_icon_list_test.go → last significant change in d1b0722034 (Jake Howell) when icon requirements were standardized.
git log --oneline -10 --follow site/static/icon/texlive.svg → 3d8d89e (DevCats) adds the new icon with a non-standard viewBox.
Assigning to @ammario as internal triage owner (assignee constraints in coder/internal). Original change is the texlive.svg addition above.
Related issues: none found in coder/internal (searched TestSVGIconAttributes, texlive.svg, generate_icon_list_test.go viewBox).
Reproduction:
go test ./scripts/gensite -run TestSVGIconAttributes/texlive.svg
CI Run: https://github.com/coder/coder/actions/runs/24372016078
Commit: 3d8d89e56cbf3a777b8eea1ac933751aa54ba800 (feat: add texlive.svg icon (#24312)) by DevCats christofer@coder.com
Failing jobs:
Error:
Root cause classification: Code change. The newly added
site/static/icon/texlive.svghasviewBox="0 0 1024 1024", which violatesTestSVGIconAttributes’s requirement forviewBox="0 0 256 256".Race detection: Searched test-go-race-pg logs for "WARNING: DATA RACE" / "race detected"; none found.
Panic/OOM: none observed.
Assignment analysis:
git blame -L 14,40 scripts/gensite/generate_icon_list_test.go→ last significant change in d1b0722034 (Jake Howell) when icon requirements were standardized.git log --oneline -10 --follow site/static/icon/texlive.svg→ 3d8d89e (DevCats) adds the new icon with a non-standard viewBox.Assigning to @ammario as internal triage owner (assignee constraints in coder/internal). Original change is the texlive.svg addition above.
Related issues: none found in coder/internal (searched TestSVGIconAttributes, texlive.svg, generate_icon_list_test.go viewBox).
Reproduction: