Skip to content

flake: Test process crash - TestWatcher_SharedParentRefcount timeout #1531

@flake-investigator

Description

@flake-investigator

CI Run: https://github.com/coder/coder/actions/runs/25779961144 (job: test-go-pg (macos-latest))
Commit: eedde58b5574017c3aac51001ee42ba630c496dd (dependabot[bot])
Failure time: 2026-05-13 05:43:12Z

Panic evidence:

panic: test timed out after 20m0s
	running tests:
		TestWatcher_SharedParentRefcount (20m0s)

... goroutine 69 [sync.Mutex.Lock, 20 minutes]:
... github.com/coder/coder/v2/agent/x/agentmcp.(*configWatcher).Close.func1()
	/Users/runner/work/coder/coder/agent/x/agentmcp/configwatcher.go:372

Assertion output before timeout:

configwatcher_internal_test.go:402:
Error: Not equal:
expected: 2
actual  : 0
Messages: refcount equals number of files

Root cause classification: Process crash (test timeout/hang in TestWatcher_SharedParentRefcount; refcount mismatch suggests watcher state not tracking dir refcount correctly and cleanup blocks).
Race/Panic/OOM evidence: panic above; no data race warnings found.

Assignment analysis:

  • git log --oneline -10 --follow agent/x/agentmcp/configwatcher_internal_test.go
    • 147f50c5 fix(agent/x/agentmcp): watch MCP config files for late-appearing or rewritten config (Kyle Carberry)
      Most recent meaningful changes to the test/feature are in 147f50c5, so assigning to kylecarbs.

Related issues: none found (searched "TestWatcher_SharedParentRefcount", "agentmcp configwatcher", "refcount equals number of files").

Reproduction: not known; intermittent in nightly gauntlet.

Metadata

Metadata

Assignees

Labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions