🤖 fix: prevent stale redirect after workspace deletion #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting a workspace, the redirect logic was using a stale closure value of selectedWorkspace. If the user navigated to another workspace while the delete was in progress, they'd still get redirected to the project page because the callback captured the old selection. Fix: Use functional update form of setSelectedWorkspace to check the *current* selection at the time the delete completes, not the value captured when the callback was created. _Generated with mux_
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a workspace, the redirect logic was using a stale closure value of
selectedWorkspace. If the user navigated to another workspace while the delete was in progress, they'd still get redirected to the project page because the callback captured the old selection.Fix: Use functional update form of
setSelectedWorkspaceto check the current selection at the time the delete completes, not the value captured when the callback was created.Generated with
mux