🤖 fix: prevent useReviews re-renders from cascading #1006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Memoize useReviews return object to prevent new object on every render - Destructure addReview in AIView and depend only on it (not whole reviews object) so handleReviewNote callback stays stable _Generated with mux_
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes re-render issues caused by unstable callback references:
useReviewsreturn object to prevent creating new object on every renderaddReviewin AIView and depend only on it (not wholereviewsobject) sohandleReviewNotecallback stays stableWithout this fix, every render creates a new
reviewsobject →handleReviewNotecallback recreated → all components receiving it re-render.Generated with mux