🤖 fix: prevent compaction summary loss from race condition #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compaction completes, there's a race between: - StreamManager continuing to deletePartial/updateHistory after emitting stream-end - CompactionHandler clearing history and appending summary - sendQueuedMessages triggering commitToHistory If commitToHistory runs before StreamManager deletes partial.json, it finds the stale partial with the OLD historySequence and appends it to history, corrupting the context and losing the compaction summary. Fix: CompactionHandler now deletes partial.json BEFORE clearing history, ensuring any concurrent commitToHistory calls find no partial and become no-ops. _Generated with mux_
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When compaction completes, there's a race condition that can cause the compaction summary to be lost from context:
stream-endthen continues todeletePartial/updateHistorysendQueuedMessagestriggerscommitToHistorycommitToHistoryfinds stalepartial.json(not yet deleted by StreamManager)commitToHistoryappends this stale message to history, corrupting contextSolution
CompactionHandler now deletes
partial.jsonBEFORE clearing history. This ensures any concurrentcommitToHistorycalls find no partial and become no-ops.Changes
src/node/services/compactionHandler.ts- Delete partial before compactionsrc/node/services/agentSession.ts- Pass partialService to CompactionHandlersrc/node/services/compactionHandler.test.ts- Test for the fixGenerated with
mux