🤖 fix: remove mock.module causing test pollution across files

[ethanndickson]

Problem

The enforceThinkingPolicy tests in policy.test.ts fail intermittently depending on test execution order. When providerOptions.test.ts runs before policy.test.ts, the policy tests fail because they receive a mocked pass-through function instead of the real implementation.

Root cause: providerOptions.test.ts uses mock.module("@/browser/utils/thinking/policy", ...) at module load time, which globally replaces the real module. Bun's mock.module does not isolate between test files—this is a known limitation.

Why it's flaky: Bun randomizes test file order. Different seeds produce different orderings:

• --seed=2: policy tests pass (providerOptions runs after policy)
• --seed=1, --seed=42, default: policy tests fail (providerOptions runs before policy)

Solution

Remove the mock.module for enforceThinkingPolicy from providerOptions.test.ts.

Why this fix is safe

The mock was added to test buildProviderOptions output formatting in isolation—passing arbitrary thinking levels without policy clamping. However, examining the tests:

• They use thinking levels ("medium", "high", "low", "off") that are valid for the models being tested
• enforceThinkingPolicy returns these levels unchanged for these model/level combinations
• The tests still pass without the mock because the real policy allows these levels

The mock was defensive but unnecessary. Removing it:

1. Fixes the flaky test
2. Follows the codebase's preference for avoiding mocks (per AGENTS.md)
3. Makes tests more honest—they now test real behavior

Verification

# Before fix (default seed): 5 failures
bun test src

# After fix: 0 failures across all seeds
bun test src                    # 1571 pass, 0 fail
bun test --seed=1 src           # passes
bun test --seed=42 src          # passes

Generated with mux

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.