🤖 fix: restore slash commands in workspace creation mode #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression introduced in #784 where slash commands were accidentally removed from creation mode during the ORPC migration. Supporting global commands like /providers in creation mode was originally introduced in #704. This PR restores that functionality with an improvement: workspace-only commands (clear, truncate, compact, fork, new) are now filtered from suggestions in creation mode rather than just showing an error toast when executed. Changes: - Restore CommandSuggestions in creation mode with portal rendering - Filter workspace-only commands from suggestions based on variant - Unify toast handling to show slash command feedback in both modes - Extract WORKSPACE_ONLY_COMMANDS to shared constant to avoid duplication
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Pull request overview
This PR restores slash command functionality in workspace creation mode that was accidentally removed during the ORPC migration. The key improvement is that workspace-only commands are now filtered from suggestions in creation mode rather than just showing an error when executed.
Key changes:
- Extracted
WORKSPACE_ONLY_COMMANDSconstant to centralize the list of commands requiring an existing workspace - Enhanced suggestion filtering to respect creation vs workspace variant contexts
- Unified toast rendering to support slash command feedback in both modes
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/constants/slashCommands.ts | New file defining workspace-only commands as a shared constant |
| src/browser/utils/slashCommands/types.ts | Added variant field to SlashSuggestionContext to distinguish creation from workspace mode |
| src/browser/utils/slashCommands/suggestions.ts | Updated suggestion filtering logic to exclude workspace-only commands in creation mode |
| src/browser/utils/chatCommands.ts | Replaced hardcoded workspace commands array with shared constant |
| src/browser/components/ChatInput/index.tsx | Restored CommandSuggestions component in creation mode with portal rendering and unified toast handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #784 where slash commands were accidentally removed from creation mode during the ORPC migration.
Supporting global commands like
/providersin creation mode was originally introduced in #704. This PR restores that functionality with an improvement: workspace-only commands (clear,truncate,compact,fork,new) are now filtered from suggestions in creation mode rather than just showing an error toast when executed.Changes
CommandSuggestionsin creation mode with portal rendering (to escapeoverflow:hiddencontainers)WORKSPACE_ONLY_COMMANDSto shared constant to avoid duplication between suggestion filtering and command executionGenerated with
mux