🤖 fix: scroll slash command suggestions to follow keyboard selection #1014
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Pull request overview
This PR improves keyboard navigation in the slash command suggestions dropdown by ensuring that the selected item remains visible as users navigate with arrow keys. Previously, keyboard selection could move outside the visible scroll area.
Key changes:
- Added automatic scrolling to follow keyboard selection in the command suggestions list
- Implemented a ref-based approach to track and scroll to the selected item
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ethanndickson
force-pushed
the
slash-commands-scrolling-view
branch
from
ef797c0 to
218361f
Compare
When navigating slash commands with arrow keys, the dropdown now scrolls to keep the selected item visible. Previously, the selection would move outside the visible area without the view following. _Generated with mux_
ethanndickson
force-pushed
the
slash-commands-scrolling-view
branch
from
218361f to
dcf8ba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When navigating slash commands with arrow keys, the dropdown now scrolls to keep the selected item visible. Previously, the selection would move outside the visible area without the view following.
Generated with
mux