🤖 fix: use functional update for project expand/collapse state #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toggleProject function had a stale closure issue - it read from expandedProjects which was recreated on every render. When clicking rapidly, subsequent clicks could use stale state. Changed to use functional update pattern with setExpandedProjectsArray to always get the current state directly from React.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes project expand/collapse bug where clicking one project could affect another project's state.
The
toggleProjectfunction had a stale closure issue - it read fromexpandedProjectswhich was a new Set recreated on every render. When clicking rapidly, subsequent clicks could use stale state from an earlier render.Changed to use functional update pattern with
setExpandedProjectsArrayto always get the current state directly from React.Generated with
mux