🤖 ci: add Windows build to PR/merge queue and EV code signing to releases #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
ibetitsmike
force-pushed
the
windows-cli-code-signing
branch
from
cbb29fa to
8de6ab9
Compare
…ases - Add Windows build job to build.yml (runs on PRs and merge queue) - Add Windows EV code signing with GCP KMS and jsign (mirrors coder-desktop-windows pattern) - Custom signing script at scripts/sign-windows.js for electron-builder - Uses repository variables for non-sensitive config (EV_KEYSTORE, EV_KEY, EV_TSA_URL) - Uses secrets for sensitive data (EV_SIGNING_CERT, GCP_WORKLOAD_ID_PROVIDER, GCP_SERVICE_ACCOUNT) - Gracefully skips signing if secrets not configured _Generated with `mux`_
ibetitsmike
force-pushed
the
windows-cli-code-signing
branch
from
8de6ab9 to
5c71b19
Compare
ibetitsmike
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Windows EV code signing using jsign + GCP Cloud KMS (same approach as coder/coder).
Changes
scripts/sign-windows.jsfor electron-builderRequired repo configuration (already done)
EV_KEYSTORE,EV_KEY,EV_TSA_URL,GCP_WORKLOAD_ID_PROVIDER,GCP_SERVICE_ACCOUNTEV_SIGNING_CERTGenerated with
mux