Skip to content

Conversation

@ibetitsmike
Copy link
Contributor

@ibetitsmike ibetitsmike commented Dec 9, 2025

Generated with mux

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

Add console.log statements to diagnose why electron-builder
isn't calling the custom signing script during releases.

_Generated with mux_
@ibetitsmike ibetitsmike force-pushed the windows-mux-exe-signing branch from 78594f5 to 03cb22c Compare December 9, 2025 12:55
Add EV code signing setup to the PR build-windows job so we can
test signing on PRs instead of only on releases.

_Generated with mux_
Signing works - confirmed on PR. Remove test setup.

_Generated with mux_
@ibetitsmike ibetitsmike changed the title 🤖 fix: move Windows sign config into signtoolOptions 🤖 fix: log signature process for traceability Dec 9, 2025
@ibetitsmike ibetitsmike added this pull request to the merge queue Dec 9, 2025
Merged via the queue into main with commit 8823ca8 Dec 9, 2025
17 of 19 checks passed
@ibetitsmike ibetitsmike deleted the windows-mux-exe-signing branch December 9, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant