🤖 perf: skip redundant bun cache restore when node_modules exists #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic checked cache-hit output which is false for partial restore-key matches. This caused Windows builds to unnecessarily: 1. Download and decompress the 275MB bun install cache (~88 seconds) 2. Run bun install (which was a no-op since node_modules existed) 3. Re-save both caches at job end (~77 seconds) The fix checks if node_modules/.bin actually exists after cache restore, which is more reliable than the cache-hit output for determining if we need to install dependencies. Expected time savings: ~88-165 seconds on Windows builds (was ~8m, should be ~6m or less). _Generated with mux_
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Windows builds were taking ~8 minutes, with setup-mux taking ~2.5 minutes.
Root Cause
The
cache-hitoutput fromactions/cacheisfalsefor partial restore-key matches. This caused:cache-hit='false'bun installruns but is a no-op (node_modules exists)Timeline breakdown (from this run):
Solution
Check if
node_modules/.binactually exists after cache restore, instead of relying oncache-hitoutput. This is more reliable for determining if we need to install dependencies.Expected improvement
~88-165 seconds saved on Windows builds when lockfile hash changes (partial cache hit scenario).
Generated with
mux