🤖 fix: raise MCP image guard to 8MB, add JPEG test matrix #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Raise MAX_IMAGE_DATA_BYTES from 16KB to 8MB per image - AI SDK v5 properly converts media tool results to image blocks - Previous limit was unnecessarily restrictive for normal screenshots - New limit guards against pathological payloads while allowing typical images - Tighten IPC integration tests for MCP image handling: - Add JPEG format test alongside existing PNG test - Assert no text parts contain data URIs or large base64 blobs - Verify model response includes 'example domain' to prove image was read - Ensures regression detection if SDK ever serializes images as text _Generated with mux_
ammar-agent
force-pushed
the
mcp-context-exceeded-jpeg
branch
from
cfba242 to
6e7475a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes MCP image handling that was unnecessarily restricting screenshots to 16KB.
Changes
Raise MAX_IMAGE_DATA_BYTES from 16KB to 8MB per image
{ type: "media", mediaType, data }tool results into native image blocks for providers (Anthropic, OpenAI)Tighten IPC integration tests for MCP image handling:
data:imageURIs or large base64 blobs (≥10k chars)Testing
bun test src/node/services/mcpResultTransform.test.ts✅TEST_INTEGRATION=1 bun x jest tests/ipc/mcpConfig.test.ts -t "MCP image"✅make static-check✅Generated with
mux