🤖 fix: show user messages immediately without deferral #1041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user sends a message, useDeferredValue was causing a delay before the message appeared in the chat window. This created bad UX where the input was cleared but the message wasn't visible anywhere. The fix compares message counts between the current and deferred values. When the count differs (new message added), we show immediately. When only content changes (streaming deltas), we still defer for performance. This preserves the streaming optimization from commit 5cc443d while ensuring user messages appear instantly.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a UX issue where there was an occasional delay between sending a message and it appearing in the chat window. During this delay, the input was cleared but the user message wasn't visible anywhere.
Root Cause
useDeferredValue(added in #1004 to improve streaming performance) was deferring all message list updates, including new user messages. This is correct for streaming deltas (where rapid updates benefit from deferral) but wrong for user-initiated messages (where immediate feedback is expected).Fix
Compare the message counts between the current and deferred values:
This preserves the streaming optimization while ensuring user messages appear instantly.
Testing
make static-check✅make teston WorkspaceStore ✅Generated with
mux