🤖 fix: simplify Editor settings UI #1042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant 'Editor' section header - now just a single row - Remove 'Use Remote-SSH' checkbox - SSH workspaces always use Remote-SSH when the editor supports it (VS Code/Cursor) - Remove useRemoteExtension from EditorConfig type and storage The previous UI was unnecessarily complex. For SSH workspaces, there's no other sensible path than Remote-SSH, so the checkbox was just noise. The editor itself handles the case when the extension isn't installed (prompts user to install it).
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Member
|
cc @ibetitsmike |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the Editor settings in the General section:
useRemoteExtensionfromEditorConfigtype and storageFor SSH workspaces, there's no other sensible path than Remote-SSH, so the checkbox was unnecessary. When users click 'Open in Editor' on an SSH workspace with VS Code/Cursor, it just works. If the Remote-SSH extension isn't installed, the editor itself prompts to install it.
Generated with
mux