🤖 fix: preserve review state when renaming workspaces #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getReviewStateKey function was defined locally in useReviewState.ts but not included in PERSISTENT_WORKSPACE_KEY_FUNCTIONS, so review state (which hunks were marked as read) was not migrated during workspace rename. Moved getReviewStateKey to storage.ts and added it to the migration list. _Generated with mux_
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getReviewStateKeyfunction was defined locally inuseReviewState.tsbut not included inPERSISTENT_WORKSPACE_KEY_FUNCTIONS, so review state (which hunks were marked as read) was not migrated during workspace rename.Fix: Moved
getReviewStateKeytostorage.tsand added it to the migration list.Generated with
mux