🤖 fix: make bulk review story ordering deterministic #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
ammar-agent
force-pushed
the
bulk-review-comment-ordering
branch
from
d43f02d to
5d7aae8
Compare
The BulkReviewActions story was unstable because createReview() used Math.random() for createdAt timestamps, causing reviews to appear in different orders on each render. Fix: Add optional createdAt parameter to createReview() and pass deterministic timestamps in the story. _Generated with mux_
ammar-agent
force-pushed
the
bulk-review-comment-ordering
branch
from
5d7aae8 to
4066370
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BulkReviewActionsstory was unstable becausecreateReview()usedMath.random()forcreatedAttimestamps, causing reviews to appear in different orders on each render.Fix: Add optional
createdAtparameter tocreateReview()and pass deterministic timestamps in the story.Also adds guidance to AGENTS.md: keep story data deterministic to avoid visual instability.
Generated with
mux