🤖 feat: allow unlimited bash_output timeout with queued message interruption #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption - Remove .max(15) limit from bash_output timeout_secs schema - Add abort signal support to getOutput() for stream cancellation - Add queued message detection so bash_output returns early when user sends a new message during a long wait - Update tool description to guide agents: only use long timeouts when no other useful work can be done in parallel - Add 'interrupted' status to ProcessStatusBadge UI component - Add tests for abort signal and queued message interruption The flow when user sends message during bash_output wait: 1. queueMessage() sets backgroundProcessManager.setMessageQueued(true) 2. bash_output's getOutput() polling loop detects hasQueuedMessage() 3. Returns early with status: 'interrupted' 4. tool-call-end fires, sendQueuedMessages() processes queued message
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow
bash_outputto wait for any amount of time (removing the previous 15-second limit), while ensuring the chat stays responsive by detecting when users queue new messages.Changes
1. Remove timeout limit
.max(15)constraint from the schema2. Add abort signal support
getOutput()accepts optionalabortSignalparameterstatus: "interrupted"when stream is cancelled3. Add queued message detection
setMessageQueued()/hasQueuedMessage()toBackgroundProcessManagerqueueMessage()sets the flag;sendQueuedMessages()/clearQueue()clears itgetOutput()checks for queued messages in polling loop and returns earlyFlow when user sends message during
bash_outputwait:queueMessage()→setMessageQueued(workspaceId, true)bash_output'sgetOutput()polling loop detectshasQueuedMessage() = true{ status: "interrupted", output: "(waiting interrupted)" }tool-call-endfires →sendQueuedMessages()processes queued message4. UI update
ProcessStatusBadgenow supports "interrupted" status with warning colorTesting
bash_outputtests passGenerated with
mux