🤖 fix: prevent init state persist race condition #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Fixed flaky test 'should persist init state to disk for replay across page reloads'. Root cause: endInit() updated in-memory state (exitCode) before persist completed. When called with void (fire-and-forget), replay could see exitCode !== null but file didn't exist yet. Fix: Persist state BEFORE updating in-memory exitCode, ensuring the invariant that if init-end is visible (live or replay), the file MUST exist. Also added AGENTS.md guideline about void async calls hiding race conditions.
ammar-agent
force-pushed
the
fix-init-state-persist-flake
branch
from
6c41524 to
08e2d70
Compare
ammario
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed flaky test
should persist init state to disk for replay across page reloads.Root Cause
Race condition in
InitStateManager.endInit():exitCode) synchronouslypersist()was awaited to write to disklogComplete()calledendInit()withvoid(fire-and-forget)If replay happened while
persist()was still running, it would seeexitCode !== nullbut the file wouldn't exist yet.Fix
Persist state BEFORE updating in-memory
exitCode, ensuring the invariant: ifinit-endis visible (live or replay), the file MUST exist.Validation
Generated with
mux