🤖 fix: reduce flakiness in anthropic1MContext test #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
ammar-agent
force-pushed
the
test-timeout-fix-a4pf
branch
2 times, most recently
from
45de000 to
ef9c104
Compare
Token limit errors should fail immediately, but Anthropic's actual limits are unreliable to test against (they may change without notice). Instead: - Remove flakey integration test that depended on Anthropic's 200k limit - Extracted buildAnthropicHeaders() into testable pure function - Added unit tests for header building logic in aiService.test.ts The unit tests verify we send the correct header; Anthropic's enforcement of that header is their responsibility, not ours.
ammar-agent
force-pushed
the
test-timeout-fix-a4pf
branch
from
78442de to
69f3ee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token limit errors fail immediately - the API rejects the request before streaming starts. Instead of waiting for full response completion, we now race between
stream-start(accepted) vsstream-error(rejected).Changes
stream-startvsstream-error(notstream-end)buildAnthropicHeaders()into testable pure functionGenerated with
mux