🤖 fix: deterministic timestamps for review stories #1061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Pull request overview
This PR fixes non-deterministic ordering of reviews in Storybook stories by introducing explicit timestamps. The issue occurred when multiple createReview calls executed within the same millisecond, causing unstable sorting and chromatic test flakes.
Key changes:
- Added deterministic base timestamp (1700000000000) to three story setups
- Incremented timestamps for each review to ensure stable ordering
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reviews were rendering in non-deterministic order because createReview defaulted to Date.now() for timestamps. When multiple calls happened in the same millisecond, the sort became unstable. Added explicit baseTime + N timestamps to affected stories: - ReviewsBanner - AllReviewsChecked - ManyReviews This fixes chromatic flakes where review order would vary between runs. _Generated with mux_
ethanndickson
force-pushed
the
reviews-9x6d
branch
from
0edc3f0 to
00a14a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviews were rendering in non-deterministic order because
createReviewdefaulted toDate.now()for timestamps. When multiple calls happened in the same millisecond, the sort became unstable.Added explicit
baseTime + Ntimestamps to affected stories:This fixes chromatic flakes where review order would vary between runs.
Generated with
mux