🤖 feat: add editor deep links for browser mode #1078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `mux server` and accessing via browser, 'Open in Editor' now uses deep link URLs (vscode://, cursor://) instead of trying to spawn an editor process on the server machine. Configuration options for SSH hostname (in order of precedence): - CLI: `mux server --ssh-host devbox` - Environment: `MUX_SSH_HOST=devbox mux server` - Config file: `serverSshHost` in ~/.mux/config.json Scenarios handled: - Local server (localhost): Uses local file deep links - Remote server with local workspace: Uses SSH remote deep links - Remote server with SSH workspace: Uses workspace's SSH host Also adds a warning in Settings when custom editor is selected in browser mode, since custom editors can't work via deep links. _Generated with `mux`_
Adds server.setSshHost() API endpoint and SSH Host input field in Settings that appears only in browser mode. Users can now configure the SSH hostname used for editor deep links directly from the Settings UI.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
mux serverand accessing via browser, 'Open in Editor' now uses deep link URLs (vscode://,cursor://) instead of trying to spawn an editor process on the server machine.Configuration
SSH hostname can be configured in order of precedence:
mux server --ssh-host devboxMUX_SSH_HOST=devbox mux serverserverSshHostin ~/.mux/config.jsonScenarios handled
vscode://file/path/to/filevscode://vscode-remote/ssh-remote+host/pathUI Changes
Files changed
src/browser/utils/editorDeepLinks.ts- deep link URL generatorsrc/browser/hooks/useOpenInEditor.ts- browser mode detection and deep link handlingsrc/browser/components/Settings/sections/GeneralSection.tsx- SSH Host fieldsrc/cli/server.ts- added--ssh-hostflagsrc/node/services/serverService.ts- stores SSH hostsrc/common/orpc/schemas/api.ts+router.ts- exposesserver.getSshHost()andserver.setSshHost()src/common/types/project.ts+src/node/config.ts- config schema updateGenerated with
mux