Skip to content

🤖 fix: use reliable test endpoint for HTTP 404 error test #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ammario merged 1 commit into from
Dec 11, 2025
Merged

🤖 fix: use reliable test endpoint for HTTP 404 error test #1097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/node/services/tools/web_fetch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,11 +217,11 @@ describe("web_fetch tool", () => {
});

// Test HTTP error handling with body parsing
it("should include HTTP status code in error for 404 responses", async () => {
it("should include HTTP status code in error for non-2xx responses", async () => {
using testEnv = createTestWebFetchTool();
const args: WebFetchToolArgs = {
// GitHub returns a proper 404 page for nonexistent users
url: "https://github.com/this-user-definitely-does-not-exist-12345",
// httpbin.dev reliably returns the requested status code
url: "https://httpbin.dev/status/404",
};

const result = (await testEnv.tool.execute!(args, toolCallOptions)) as WebFetchToolResult;
Expand Down