🤖 fix: use ownerDocument.body for portal queries in settings stories #1107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Select switches by name instead of DOM order to prevent flaky tests when new switches are added to the Settings modal. Also simplify ExperimentsToggleOff to show default state directly rather than clicking twice (on then off).
ethanndickson
force-pushed
the
storybook-m122
branch
from
a1f3a88 to
b276990
Compare
The exact text match fails because button textContent includes icon SVG content. Using includes() is more robust.
ethanndickson
force-pushed
the
storybook-m122
branch
from
de1217b to
784f6a7
Compare
Following ~/coder patterns - use screen for dialog/portal elements instead of within(document.body). Simplifies the helper function.
ethanndickson
force-pushed
the
storybook-m122
branch
3 times, most recently
from
fa06207 to
1590636
Compare
The 'screen' from @storybook/test queries the entire page including Storybook UI, causing false matches on buttons like 'Experiments' in the sidebar. Using canvasElement.ownerDocument.body scopes queries to just the iframe content.
ethanndickson
force-pushed
the
storybook-m122
branch
from
1590636 to
7f3f630
Compare
ethanndickson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix settings modal stories to properly query portal-rendered content.
Changes:
canvasElement.ownerDocument.bodyinstead ofdocument.bodyto scope queries to the Storybook iframe (not the parent UI)findByRolewith explicit names instead of finding all elements by role and filteringExperimentsToggleOnstory instead of clicking the toggle (more deterministic, avoids timing issues withlocalStorage → useSyncExternalStore → re-renderin Chromatic)Generated with
mux