🤖 feat: line-delta git status indicator with toggle #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
When in line-delta mode with no outgoing changes but behind remote, show a muted ↓N indicator so users can hover to see details and toggle to divergence view.
ammar-agent
force-pushed
the
git-status-7fs3
branch
from
633f810 to
208fb23
Compare
The GitStatusVariations story already covers git status display. The deleted stories weren't properly showing the indicators.
- Add outgoingAdditions/outgoingDeletions to fixtures - Add ws-diverged with large counts to test abbreviation (12.3k) - Auto-expand project so workspaces are visible on load - Update comment to document what each workspace demonstrates
- Generate deterministic hex hashes (no Math.random) - Match parseGitShowBranchForStatus expectations
Avoid storybook git command mocking by exercising GitStatusIndicatorView with explicit props (line-delta, divergence, behind-only).
The MCP screenshot tests occasionally miss the tool-call-end event even after stream-end; poll briefly for chrome_take_screenshot to reduce flake.
ammar-agent
force-pushed
the
git-status-7fs3
branch
from
5841bf1 to
3abe481
Compare
- Remove component-level story (repo only uses App.* stories) - Improve executeBash mock to support both GitStatusStore + tooltip branch details - Add play interaction to GitStatusVariations to prove toggle works
ammar-agent
force-pushed
the
git-status-7fs3
branch
from
3abe481 to
52ac176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the GitStatusIndicator to show line deltas (additions/deletions) by default instead of commit divergence (ahead/behind). Users can toggle between views via the tooltip.
Summary
+{additions} -{deletions}with GitHub-style coloring (green/red when working, muted when idle)Lines/Commitssegmented control to switch views globally (persisted to localStorage)Implementation
GitStatustype withoutgoingAdditions,outgoingDeletions,incomingAdditions,incomingDeletionsgit diff --numstatagainst merge-baseGIT_STATUS_INDICATOR_MODE_KEYfor persisted global preferenceGenerated with
mux