🤖 fix: validate /compact model format before persisting message #1109
+103
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
chat-gjyz
branch
2 times, most recently
from
8343191 to
ee0de0d
Compare
- Add early model format validation in backend (agentSession.ts) to reject invalid model strings before persisting user message to history - Add frontend validation in /compact handler to fail fast with clear error - Add isValidModelFormat() helper in shared location (common/utils/ai/models.ts) - Remove eager localStorage save of compaction model preference to prevent poisoning future /compact commands with invalid model values This fixes the issue where /compact -m badmodel would show the command in chat history even though the request failed due to invalid model format.
ammar-agent
force-pushed
the
chat-gjyz
branch
from
ee0de0d to
5e68834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes janky
/compactslash-command behavior where commands with invalid model formats would show up in chat history even though the request failed.Changes
Backend validation (agentSession.ts): Validate model format before persisting user message to history. Invalid model strings (missing provider prefix) are now rejected before the message is saved, preventing orphaned compaction request messages.
Frontend validation (chatCommands.ts): Fail fast in
/compacthandler when model format is invalid, showing a clear toast error with example format.Helper function: Add
isValidModelFormat()to check forprovider:model-idformat (supports colons in model ID for ollama-style names).Preference poisoning fix: Stop eagerly saving compaction model to localStorage, preventing invalid model values from affecting future
/compactcommands.Testing
isValidModelFormat()Generated with
mux