🤖 fix: gateway toggle double-toggle race condition #1114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix GatewayIcon not forwarding refs (React warning) - Make gateway icon clickable on main page to toggle gateway - Remove redundant updatePersistedState calls that caused double-toggle The bug: setEnabledModels() from usePersistedState already writes to localStorage synchronously, but updatePersistedState() was also called, reading the already-toggled value and toggling again, reverting changes.
Member
Author
|
Already fixed by #1112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
updatePersistedStatecalls that caused double-toggle bugRoot cause
setEnabledModels()fromusePersistedStatealready writes to localStorage synchronously, butupdatePersistedState()was also being called. This read the already-toggled value from localStorage and toggled it again, effectively reverting the change.Test plan
Generated with Claude Code