Skip to content

🤖 refactor: dedupe create-workspace vs send-message keybinds #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ammario merged 1 commit into from
Dec 12, 2025
Merged

🤖 refactor: dedupe create-workspace vs send-message keybinds #1122

ammario merged 1 commit into from
Dec 12, 2025

Conversation

@ammar-agent
Copy link
Collaborator

@ammar-agent ammar-agent commented Dec 12, 2025

Refactors shared UI logic between the workspace creation flow and the existing-workspace send flow.

  • Centralize ImageAttachment[] → ImagePart[] conversion (with optional validation)
  • Remove hardcoded cancel key label in creation placeholder (use KEYBINDS.CANCEL)
  • Unify send-in-flight state used for disabling creation controls + overlay

Validation:

  • make static-check

Generated with mux

@ammario ammario merged commit 3594896 into main Dec 12, 2025
20 checks passed
@ammario ammario deleted the workspace-be0n branch December 12, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ammar-agent @ammario