Skip to content

Conversation

@ammar-agent
Copy link
Collaborator

Generated with mux

Follow-up to #1125 - adds Storybook coverage for the RightSidebar tab styling changes.

Changes

  • ORPC mock enhancements:

    • Add MockSessionUsage type matching SessionUsageFileSchema
    • Add sessionUsage option to mock client factory
    • Wire up getSessionUsage to return mock data per workspace
  • Story helper updates:

    • Extend setupSimpleChatStory to accept sessionUsage option
  • New stories (App/RightSidebar):

    • CostsTabWithCost: Shows tab with \bash.56 session cost
    • CostsTabSmallCost: Shows $<0.01 for tiny costs
    • CostsTabLargeCost: Shows \2.34 for larger sessions
    • CostsTabNoCost: Empty state (no cost in tab label)
    • ReviewTabSelected: Review panel visible
    • SwitchToReviewTab: Interaction test for tab switching

@ammar-agent ammar-agent force-pushed the storybook-sidebar-tabs branch 2 times, most recently from 283b008 to 2cbac45 Compare December 12, 2025 17:47
- Add MockSessionUsage type and getSessionUsage mock to ORPC mock client
- Extend setupSimpleChatStory to support sessionUsage option
- Add App.rightsidebar.stories.tsx with 2 stories:
  - CostsTab: Shows Costs tab with $0.56 session cost in tab label
  - ReviewTab: Switches to Review tab via play function
- Use wide viewport (1600px) to ensure RightSidebar is visible
@ammar-agent ammar-agent force-pushed the storybook-sidebar-tabs branch from 2cbac45 to cc09ab0 Compare December 12, 2025 17:47
@ammario ammario merged commit 31a8455 into main Dec 12, 2025
20 checks passed
@ammario ammario deleted the storybook-sidebar-tabs branch December 12, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants