🤖 perf: fix diff 'Processing' flash with module-level cache #1150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diff renderer was showing 'Processing...' frequently because: - useState initialized as null even when the same diff was already highlighted - The existing cache in highlightWorkerClient was async (required hash lookup) Fix: - Add module-level LRU cache (highlightedDiffCache) storing full HighlightedChunk[] - Synchronous cache lookup during render via 'cachedResult ?? chunks' - Remove redundant async cache from highlightWorkerClient (now handled at higher level) - Preserve hasRealHighlightRef to prevent downgrade when enableHighlighting toggles off
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Diffs frequently displayed "Processing..." even for previously-viewed content, causing visual flicker when scrolling through messages.
Root Cause
useHighlightedDiffinitialized state asnull- even cached content required async operationshighlightWorkerClientwas async (required hash lookup viagetCacheKey)Solution
highlightedDiffCache) storing fullHighlightedChunk[]resultscachedResult ?? chunksreturns immediatelyhighlightWorkerClient(caching now at higher level)hasRealHighlightRefto prevent downgrade whenenableHighlightingtoggles off (viewport optimization)Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high