🤖 perf: cache review panel diff/tree to speed up workspace switching #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant cache prefix from key (git command already distinguishes) - Merge reviewPanelDiffCache and reviewPanelFileTreeCache into one - Remove cache param from executeWorkspaceBashAndCache helper --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high`_
Remove getInitialDiffState and readPersistedState usage. Cache hits in the effect are fast enough (~16ms) that the brief loading state is not user-visible. This removes duplicated cache-key logic and simplifies the code. --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high`_
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cache git diff and file tree results in a module-scope LRU cache so switching back to a previously visited workspace is near-instant.
Changes
Testing
make static-checkpassesGenerated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high