🤖 fix: diff padding background colors match first/last line type #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
ammar-agent
force-pushed
the
diffs-cayn
branch
4 times, most recently
from
6d1c98a to
425ce0b
Compare
When a diff starts with an addition or ends with a deletion, the top/bottom padding of the diff container now matches that line's background color (green for additions, red for deletions). Previously, the container used a neutral background for all padding regardless of the first/last line types, causing a visual inconsistency. Changes: - Added firstLineType/lastLineType props to DiffContainer - Replaced py-1.5 padding with separate colored padding strips - Updated DiffRenderer and SelectableDiffRenderer to pass line types - Added DiffPaddingColors story to capture the behavior --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high`_
ammar-agent
force-pushed
the
diffs-cayn
branch
from
425ce0b to
496f2e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a diff starts with an addition or ends with a deletion, the top/bottom padding of the diff container now matches that line's background color (green for additions, red for deletions).
Previously, the container used a neutral background for all padding regardless of the first/last line types, causing a visual inconsistency.
Changes
firstLineType/lastLineTypeprops toDiffContainerpy-1.5padding with separate colored padding stripsDiffRendererandSelectableDiffRendererto pass line typesDiffPaddingColorsstory to capture the behaviorGenerated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high