🤖 fix: diff padding strip font alignment #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
The PaddingStrip component used ch units in gutterWidth calculation but lacked font-monospace class. Since ch units are relative to the font's character width, the padding strip was misaligned with the actual DiffLineGutter which uses font-monospace. Add font-monospace to PaddingStrip so ch units match DiffLineGutter. --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high`_
ammar-agent
force-pushed
the
fix-diff-padding-alignment
branch
from
d54b2dd to
ced4729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PaddingStrip component used
chunits in itsgutterWidthcalculation but lacked thefont-monospaceclass. Sincechunits are relative to the font's "0" character width, the padding strip was misaligned with the actualDiffLineGutterwhich usesfont-monospace.Fix
Add
font-monospaceto PaddingStrip sochunits match DiffLineGutter.Verification
The
DiffPaddingColorsstory demonstrates diffswith colored padding (additions at top, deletions at bottom). Before the fix, the colored padding strip edge was misaligned with the line number gutter.Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high