🤖 fix: support Electron flags (--no-sandbox) in packaged AppImage #1183
+71
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Distinguish CLI flags (--help, --version) from Electron flags (--no-sandbox) - CLI flags show help/version; Electron flags launch desktop - Export CLI_GLOBAL_FLAGS constant with sync documentation - Add runtime sanity check in dev mode for flag consistency - Add tests for packaged Electron flag handling (31 total)
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
./mux.AppImage --no-sandboxand other Electron flags not working - they were incorrectly falling through to CLI help instead of launching the desktop app.Problem
After the previous CLI argv fix (#1161), Electron flags like
--no-sandboxin packaged AppImage were treated as unknown CLI arguments:Root Cause
isElectronLaunchArg()immediately returnedfalsefor all packaged Electron flags, not distinguishing between:--help,--version) → should show CLI help--no-sandbox,--disable-gpu) → should launch desktopSolution
CLI_GLOBAL_FLAGSconstant listing flags that should show CLI helpisElectronLaunchArg()to returntruefor non-CLI flags in packaged modeManual Test Results
./mux.AppImage --no-sandbox./mux.AppImage --disable-gpu./mux.AppImage --help./mux.AppImage --version./mux.AppImage server --helpbunx electron . --no-sandboxGenerated with
mux• Model:anthropic:claude-sonnet-4-20250514• Thinking:low