🤖 fix: stabilize scroll position in CodeBlocks story to prevent flaky snapshots #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
force-pushed
the
markdown-view-cgh8
branch
from
2f80682 to
07025a0
Compare
ethanndickson
changed the title
ethanndickson
force-pushed
the
markdown-view-cgh8
branch
from
07025a0 to
1f9233b
Compare
ethanndickson
changed the title
… snapshots The story was flaky because useAutoScroll's ResizeObserver fires when Shiki highlighting completes, causing scroll-to-bottom which shifts elements by a few pixels. Fix: - Wait for all 3 code-block-wrappers to have Shiki spans (ensures highlighting done) - Scroll to top after highlighting and wait a frame for ResizeObserver to settle
ethanndickson
force-pushed
the
markdown-view-cgh8
branch
from
1f9233b to
b10c8d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CodeBlocks story was flaky because
useAutoScroll's ResizeObserver fires when Shiki highlighting completes, causing scroll-to-bottom which shifts elements by a few pixels.Fix:
.code-block-wrapperelements to have Shiki spans (ensures highlighting is done)Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high