🤖 fix: ensure caught-up is always sent during workspace loading #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent workspaces from getting stuck in 'Loading workspace...' state when errors occur during history replay. Root cause: emitHistoricalEvents could fail before sending caught-up. If readPartial, replayStream, or replayInit threw an exception, the caught-up message would never be sent, leaving the frontend stuck. Fix: Wrap replay logic in try/finally - the finally block guarantees caught-up is always sent regardless of what happens during replay. --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high`_
ammar-agent
force-pushed
the
workspace-loading-znhk
branch
from
698bb2b to
ad4bd58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent workspaces from getting stuck in 'Loading workspace...' state when errors occur during history replay.
Root cause
emitHistoricalEventscould fail before sendingcaught-up. IfreadPartial,replayStream, orreplayInitthrew an exception, thecaught-upmessage would never be sent, leaving the frontend stuck in the loading state indefinitely with no indication of what went wrong.Fix
Wrap replay logic in
try/finally- thefinallyblock guaranteescaught-upis always sent regardless of what happens during replay. This is clear by construction rather than relying on error handling.Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high