🤖 fix: increase storybook helper timeout for CI cold start #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The waitForChatMessagesLoaded helper had a 5s timeout which was too short for CI cold-start scenarios. When Storybook tests run in CI, the first test(s) can take longer due to loading large dependencies like Shiki and Mermaid. The error 'Messages not loaded yet' appeared in CI run 20416096418 for TaskWorkflow story. Bumped timeout from 5s to 15s to match the fix in App.markdown.stories.tsx (fcecf80) for the same cold-start issue. --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes intermittent flakes in Storybook tests (including TaskWorkflow) during CI cold-start scenarios.
Problem
The
waitForChatMessagesLoadedhelper instoryPlayHelpers.tsused a 5 second timeout. In CI, the first test(s) can take longer to load due to large dependencies (Shiki, Mermaid) being initialized. This caused failures with the error:Example failure in CI run 20416096418 for TaskWorkflow story.
Fix
Bumped timeout from 5s to 15s, matching the fix in
App.markdown.stories.tsx(fcecf80) for the same cold-start issue.Testing
make typecheckpassesGenerated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high