🤖 Add niceness parameter to executeBash for process priority control #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional niceness parameter to executeBash IPC interface - Wire through ipcMain handler to bash tool configuration - Bash tool wraps commands with nice when niceness is specified - Parameter only available at IPC level, not exposed to agents - Add ensure-deps Makefile target to auto-install dependencies
Set niceness to 19 (lowest priority) for all git-related executeBash calls in the frontend to prevent background git operations from interfering with user interactions.
ammario
approved these changes
Oct 10, 2025
sreya
pushed a commit
that referenced
this pull request
Nov 15, 2025
Fixes the regression introduced in PR #162 where complex multi-line bash scripts with conditionals would fail with exit code 2. ## Problem The original implementation wrapped commands using `JSON.stringify`, which converted newlines to literal `\n` strings: ```bash nice -n 19 bash -c "if [ \0 -ne 0 ]; then\n echo \"test\"\nfi" ``` This broke bash syntax, causing scripts with conditionals and multi-line logic to fail. ## Solution Spawn `nice` directly with proper arguments array instead of string wrapping: ```typescript spawn("nice", ["-n", "19", "bash", "-c", script], ...) ``` This avoids all escaping issues while maintaining the same niceness functionality. ## Testing Added comprehensive test coverage: - ✅ Complex multi-line scripts with conditionals (reproduces the git status regression) - ✅ Exit code handling with niceness - ✅ Simple commands with niceness All 36 tests pass including the new niceness test suite. _Generated with `cmux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional
nicenessparameter to theexecuteBashIPC call for controlling process priority. This parameter is only available at the IPC level and is not exposed to agents in tool descriptions.Changes
nicenessparameter toexecuteBashoptions (accepts -20 to 19, where lower = higher priority)nice -n <value>ensure-depsMakefile target that automatically runsbun installifnode_modulesdoesn't existTechnical Details
When niceness is provided, the bash tool wraps commands like:
nice -n 19 bash -c "original command"All git operations in GitStatusContext and GitStatusIndicator now run at lowest priority:
Generated with
cmux