Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf4fb0e300
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ammar-agent
added a commit
that referenced
this pull request
Feb 2, 2026
The recent #2101 change introduced: - Fixed w-[190px] width (too wide) - Button component with h-8 height (too tall) - ChevronDown icon in default variant Reverted to original compact styling: - Content-sized width (no fixed width) - Simple div with py-0.5 padding - No dropdown chevron in default variant --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high` • Cost: `$0.75`_ <!-- mux-attribution: model=anthropic:claude-opus-4-5 thinking=high costs=0.75 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 2, 2026
Keep aesthetic from #2101 (Button, ChevronDown, text-foreground) but use h-auto with py-0.5 instead of size="sm" (h-8) for compact height. Also removed fixed w-[190px] width - now content-sized. --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high` • Cost: $0.80_ <!-- mux-attribution: model=anthropic:claude-opus-4-5 thinking=high costs=0.80 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 2, 2026
Keep aesthetic from #2101 (Button, ChevronDown, text-foreground) but use h-auto with py-0.5 instead of size="sm" (h-8) for compact height. Also removed fixed w-[190px] width - now content-sized. --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high` • Cost: $0.80_ <!-- mux-attribution: model=anthropic:claude-opus-4-5 thinking=high costs=0.80 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 2, 2026
Reverts trigger to simple div without chevron: - No fixed width (content-sized) - Minimal padding (py-0.5 px-1) - No ChevronDown (help indicator already signals interactivity) - text-muted-light color --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high` • Cost: $0.88_ <!-- mux-attribution: model=anthropic:claude-opus-4-5 thinking=high costs=0.88 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 2, 2026
Reverts trigger to simple div without chevron: - No fixed width (content-sized) - Minimal padding (py-0.5 px-1) - No ChevronDown (help indicator already signals interactivity) - text-muted-light color --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high` • Cost: $0.88_ <!-- mux-attribution: model=anthropic:claude-opus-4-5 thinking=high costs=0.88 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 2, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 2, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 2, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 2, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 3, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 3, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 3, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 3, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 3, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 3, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 3, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 3, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 3, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 3, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 3, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 3, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammar-agent
added a commit
that referenced
this pull request
Feb 3, 2026
Keep the #2101 ModelSelector aesthetic, but reduce excess vertical space: - Reduce default-variant trigger button height (override Button size sm h-8 -> h-7) - Tighten dropdown search/header padding - Tighten model row padding - Tighten footer padding + settings row padding --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: $2.23_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=2.23 -->
ammario
pushed a commit
that referenced
this pull request
Feb 3, 2026
## Summary Refines the ModelSelector UI from PR #2101 to reduce vertical and horizontal space while keeping the darker background aesthetic. Also streamlines the ThinkingSlider (using left/right paddles instead of a slider) and tightens the ContextUsageIndicatorButton layout. ## Background PR #2101 introduced a refreshed ModelSelector design, but the trigger was too large—causing excess vertical height in the ChatInput row. This PR keeps the visual style (darker `bg-background`, chevron, ghost button) while making the control more compact. ## Implementation **ModelSelector (`ModelSelector.tsx`):** - Fixed width `w-32` for non-box variant to prevent layout shift - Tighter dropdown padding: search header `py-1`, list rows `py-0.5`, footer `py-1` - Button uses smaller padding `px-1.5 py-0.5` **ThinkingSlider (`ThinkingSlider.tsx`):** - Replaced slider UI with left/right chevron paddles - Shortened labels: OFF, LOW, MED, HIGH, MAX (stored in `DISPLAY_LABELS`) - Fixed width `w-[4ch]` for label to prevent layout shift - Active/inactive paddle states based on available thinking levels **ContextUsageIndicatorButton (`ContextUsageIndicatorButton.tsx`):** - Narrower token meter (`w-12`, up from wider default) - Removed hours text from idle compaction badge; shows hourglass icon only - Popover idle compaction section: "Idle compaction" label, smaller hourglass icon (`h-2.5 w-2.5`) --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high` • Cost: `$9.92`_ <!-- mux-attribution: model=anthropic:claude-opus-4-5 thinking=high costs=9.92 -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #2063