🤖 fix: move ai-tokenizer to dependencies #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai-tokenizer was in devDependencies but is imported at runtime in src/utils/main/tokenizer.ts. This caused "Cannot find module 'ai-tokenizer'" errors in production Electron builds since devDependencies are excluded from the packaged app. _Generated with `cmux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ai-tokenizerwas indevDependenciesbut is imported at runtime insrc/utils/main/tokenizer.ts. This caused "Cannot find module 'ai-tokenizer'" errors in production Electron builds since devDependencies are excluded from the packaged app.Solution
Moved
ai-tokenizerfromdevDependenciestodependenciesin package.json.Generated with
cmux