🤖 feat: immersive keyboard-first code review mode#2448
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a91db7631
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ibetitsmike
force-pushed
the
mike/immersive-review
branch
from
5a91db7 to
cf6e7d9
Compare
|
@codex review Addressed both unresolved review threads:
Please take another look. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 205e01d084
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed both latest comments:
Please re-review. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe46eb0182
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed latest feedback:
Please review again. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca76bb1d52
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed latest issue by resolving notes->hunk targeting against the unfiltered hunk set ( Please review again. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 012686220e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed latest feedback by treating collapsed sidebar as no mounted review panel when deciding whether immersive mode can stay enabled. Please re-review. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34782b7821
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34782b7821
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed latest P1s:
Please review again. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9241a37c30
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed latest threads:
Please re-review. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c11dacf72c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed latest focus/interaction issue by applying/removing Please review again. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c741a9aec5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c741a9aec5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed latest inert mount-path issue by rerunning inert synchronization when the shell transitions out of placeholder/loading state. Please re-review. |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@codex review Addressed the workspace-switch case by rerunning inert synchronization on workspace changes, so newly mounted pane wrappers receive inert when immersive is already active. Please review again. |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@codex review Pushed the latest immersive review follow-ups, including row-height stabilization and a new mixed highlight-vs-plain Storybook verification story. Local |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 763bd8be89
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed the Shift+I stale-closure toggle issue in Local |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@codex review Added two immersive review UX updates:
Local |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5c5a88792
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed two follow-up immersive regressions:
Also retained the new Local |
|
@codex review Addressed the latest feedback: immersive Also includes the prior follow-up fixes:
Local |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c57dd1baa
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Deep-review follow-up fixes are now pushed:
Local |
|
@codex review Addressed the sticky-composer concern in
Also re-ran local |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@codex review Applied another deep-review follow-up pass and fixed the remaining actionable items:
Local |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
The buildQuickLineReviewNote and buildQuickHunkReviewNote functions in src/browser/utils/review/quickReviewNotes.ts were never imported by any production code since their introduction in PR #2448 (Feb 2026). Remove the module and its test file (482 lines of dead code).
The buildQuickLineReviewNote and buildQuickHunkReviewNote functions in src/browser/utils/review/quickReviewNotes.ts were never imported by any production code since their introduction in PR #2448 (Feb 2026). Remove the module and its test file (482 lines of dead code).
The buildQuickLineReviewNote and buildQuickHunkReviewNote functions in src/browser/utils/review/quickReviewNotes.ts were never imported by any production code since their introduction in PR #2448 (Feb 2026). Remove the module and its test file (482 lines of dead code).
The buildQuickLineReviewNote and buildQuickHunkReviewNote functions in src/browser/utils/review/quickReviewNotes.ts were never imported by any production code since their introduction in PR #2448 (Feb 2026). Remove the module and its test file (482 lines of dead code).
1 participant
Summary
Introduces immersive, keyboard-first code review and hardens it through iterative UX/performance/layout fixes:
Shift+Lcomment,Shift+Ddislike)Eshortcut to jump to selected note and start editing immediatelyEsc) and bottom-of-viewport comment targetingBackground
Immersive mode started as a full-screen overlay for fast keyboard review. Follow-up feedback required coherent whole-file context, better line-level composition, robust note navigation under filters, and smoother behavior on large files. Additional regressions around keyboard handling and comment placement were fixed iteratively. A deep-review pass then highlighted composer-state and keybinding consistency issues that are now addressed.
Implementation
Immersive review UX
Shift+Iopens/toggles immersive mode globally viaRightSidebar.n/pnavigate files,k/jnavigate hunks, arrow keys move/extend line selection.Inline composition + notes workflow
Ekey flow: with a selected note, it navigates to the note and opens that inline review note directly in edit mode.Sentiment icon consistency
Shift+Dquick notes retain thumbs-down behavior.Shift+Lquick notes now render a thumbs-up icon in the immersive notes list.Regression hardening
Esccancels local editing without triggering higher-level immersive shortcuts.Tabpanel switching ignores editable targets, so typing/editing in inline note textareas keeps focus stable.Deep-review follow-up fixes
SelectableDiffRenderersynchronizes external composer state by request ID to avoid clobbering in-progress drafts from incidental selection churn.h/ltou/r, keeping immersiveh/lfor file navigation.flattenFileTreeLeavesbuildQuickLineReviewNotePerformance and correctness
Accessibility + layout stability
WorkspaceShell).Debug/verification story
Validation
make static-checkmake typecheckmake lintbun test src/browser/utils/review/navigation.test.ts src/browser/utils/review/quickReviewNotes.test.tsbun run eslint src/browser/components/RightSidebar/CodeReview/ImmersiveReviewView.tsx src/browser/components/shared/DiffRenderer.tsx src/browser/components/shared/InlineReviewNote.tsxReviewTabImmersiveHighlightVsPlainHeightconfirms highlighted and plain rows both render at~15.391px.Risks
inertsupport is broad in modern browsers/Electron, but still integration-sensitive around focus in complex nested trees.Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$27.16