🤖 Preserve git status on timeout/failure #251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When git status checks fail (timeout, parse error, network issues), the store was clearing the cached status and setting it to
null. This caused the git indicators in the UI to disappear during transient failures, creating visual flicker and losing useful information.Before:
After:
Solution
Only update
statusCachewhen the new status check succeeds (non-null). On failure:Scenarios This Helps
Testing
Added unit tests to verify:
checkWorkspaceStatusreturns nullAll 489 tests pass.
Generated with
cmux