🤖 fix: exclude auto from agent cycling, hide hints, fix color flash#2635
🤖 fix: exclude auto from agent cycling, hide hints, fix color flash#2635ibetitsmike merged 3 commits intomainfrom
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3630271f7c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3630271f7c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed both P2 comments: |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
ibetitsmike
changed the title
|
@codex review Added a fix to also hide the |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
Summary
Four targeted fixes for the agent picker's
Ctrl+.cycle shortcut and associated UI hints.Background
Ctrl+.cycles through alluiSelectableagents including "auto". Since auto is a meta-mode (not a concrete agent), it should only be toggled explicitly via the picker switch.Ctrl+.still works (cycling away from auto) and both the?tooltip and the bottom-of-chat shortcut hint still show the "Cycle/change agents" hint. All should be suppressed.border-colorover 150ms viatransition-all, but the textarea border snaps instantly (no transition). The mismatch produces a visible color flash during agent switches.Implementation
cycleToNextAgent(AgentContext.tsx) — Early-return when active agent is"auto"AND auto is available in the discovered agent list. Filter out"auto"from the cycle list so it's never a destination. Stale persisted "auto" still allows keyboard recovery.AgentHelpTooltip(AgentModePicker.tsx) — AddedisAutoprop; conditionally hides the "Cycle agents" hint when auto is selected.ChatInput/index.tsx) — Conditionally hides the⌘. - change agentbottom hint when auto mode is active.AgentModePicker.tsx) — Changedtransition-all→transition-[background-color]so only hover-bg animates; border-color now snaps instantly to match the textarea.Generated with
mux• Model:anthropic:claude-opus-4-6• Thinking:xhigh• Cost:$2.30