🤖 Add Haiku 4-5 support and centralize default model logic #267
+1,236
−333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
haiku
branch
3 times, most recently
from
4d39b5a to
a2d70c8
Compare
- Add claude-haiku-4-5 to MODEL_ABBREVIATIONS with 'haiku' shortcut - Add pricing/config for Haiku 4-5 to models-extra.ts ($1/$5 per million tokens) - Reorder MODEL_ABBREVIATIONS to put sonnet first (becomes default for new chats) - Centralize default model logic: created getDefaultModelFromLRU() in useModelLRU.ts - Remove all imports of defaultModel except in models.ts and useModelLRU.ts - Update all code paths to use LRU for default model selection: - useSendMessageOptions hook - getSendOptionsFromStorage (non-hook) - useAIViewKeybinds - Debug scripts (costs, agentSessionCli, send-message) - Update models.json with latest model pricing data from LiteLLM This makes the system less prescriptive - the most recently used model becomes the default for new chats, creating a natural user-driven flow.
This comment was marked as resolved.
This comment was marked as resolved.
When a user selects a model via ModelSelector, it now updates both: 1. The workspace-specific model storage (model:<workspaceId>) 2. The global LRU cache (most recently used models) This ensures that newly selected models become the default for new workspaces, creating a natural user-driven flow where the most recently used model is suggested first.
Initialize LRU with defaults immediately instead of waiting for useEffect. This prevents crashes when components access recentModels[0] before the useEffect has run to seed the LRU with default models. Changes: - usePersistedState now initializes with DEFAULT_MODELS instead of [] - useEffect simplified to only handle merging new defaults - getDefaultModelFromLRU uses same default initialization - LRU is now never empty, even on first render Fixes crash reported by Codex where ModelSelector calls .trim() on undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for Claude Haiku 4-5 (released today) and simplifies default model selection by centralizing logic in the LRU system.
Changes
Haiku 4-5 Support
haiku: "anthropic:claude-haiku-4-5"to MODEL_ABBREVIATIONSmodels-extra.ts:Centralized Default Model Logic
Problem:
defaultModelwas imported in 7+ files, spreading model prescription throughout the codebase.Solution: Created
getDefaultModelFromLRU()helper that reads the most recently used model from the LRU cache. This is now the single source of truth for default model selection.Architecture:
Updated files:
src/hooks/useModelLRU.ts- AddedgetDefaultModelFromLRU()helpersrc/hooks/useSendMessageOptions.ts- Use LRU instead of hardcoded defaultsrc/utils/messages/sendOptions.ts- Use LRU for non-hook contextssrc/hooks/useAIViewKeybinds.ts- Use LRU for keybind fallbacksModel Ordering
sonnetfirstBenefits
✅ Less prescriptive: Most recently used model becomes the default
✅ Single source of truth: Only
useModelLRU.tsimportsdefaultModel✅ Cross-workspace memory: Using Haiku in workspace A makes it default for workspace B
✅ Natural discovery: As users try models, they automatically become defaults
Testing
defaultModelnow)Generated with
cmux