🤖 Add up arrow to edit last user message #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
up-arrow
branch
2 times, most recently
from
adf442a to
d225c0d
Compare
When the input is empty and not editing, pressing up arrow now edits the last user message. This provides a quick way to iterate on messages without clicking the edit button. Also cleaned up related code: - Fixed placeholder to use CANCEL_EDIT keybind instead of CANCEL - Removed redundant empty CANCEL keybind handler - Removed redundant NEW_LINE handler (matchesKeybind already handles it) Net: +11 LOC
When pressing up arrow on empty input to edit the last user message, the view now smoothly scrolls to center the message being edited. This improves UX by making it clear which message is being edited. Net: +9 LOC
When scrolling to edit a message via up arrow, explicitly disable auto-scroll so the jump-to-bottom indicator appears immediately. Previously it wouldn't show until you manually scrolled because scrollIntoView() is programmatic scrolling which the scroll handler intentionally ignores. Net: +2 LOC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing up arrow on an empty input now edits the last user message, providing a quick way to iterate without clicking edit.
Changes
handleEditLastUserMessagecallback that finds last user messageCleanup
While implementing this, also cleaned up related code:
CANCEL_EDITkeybind instead ofCANCELCANCELkeybind handlerNEW_LINEhandler (matchesKeybindalready handles Shift+Enter)Testing
Manually test:
Generated with
cmux