🤖 fix: soften delayed-start retry banner#2839
Merged
Merged
Conversation
Avoid claiming the stream was interrupted while the first response is still stuck in pre-stream startup. Long SSH init hooks can legitimately delay stream-start even when the response will eventually begin, so the RetryBarrier now uses delayed-start copy for that state and includes a regression test. --- _Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `$2.42`_ <!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=2.42 -->
Collaborator
Author
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid showing the RetryBarrier's "Stream interrupted" copy while the first response is still waiting for stream-start.
Background
In SSH workspaces with long init hooks, the first send can stay in pre-stream startup for a while before the backend emits
stream-start. During that window the frontend still mountedRetryBarrier, which made the warning copy misleading even though the response would eventually begin.Implementation
isStreamStartingValidation
make static-checkRisks
Low. This only changes RetryBarrier copy for the pre-stream startup state; retry behavior and the actual interruption paths are unchanged.
Generated with
mux• Model:openai:gpt-5.4• Thinking:xhigh• Cost:$2.42