🤖 tests: stabilize Storybook left sidebar state#2937
Merged
Conversation
Reset Storybook's persisted left-sidebar state before each render and key AppWithMocks by story plus viewport bucket so mobile/desktop captures do not reuse stale AppLoader state. --- _Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `$2.50`_ <!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=2.50 -->
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilize Storybook app stories that were flaking because the left sidebar could inherit the previous story's persisted open/closed state.
Background
Stories such as "All Reviews Checked" could render with the wrong left-sidebar visibility when Storybook reused localStorage and an existing AppLoader instance across captures. That made visual snapshots depend on whichever story ran before them.
Implementation
LEFT_SIDEBAR_COLLAPSED_KEYbefore each Storybook render using the same mobile/desktop default that the app usesAppWithMocksby story id plus a viewport bucket so crossing the mobile breakpoint forces a freshAppLoadermountValidation
make static-checkmake storybook-buildRisks
Low risk. The change is isolated to Storybook wiring and only affects how persisted sidebar state is seeded for stories.
Generated with
mux• Model:openai:gpt-5.4• Thinking:xhigh• Cost:$2.50